New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --UsePaket flag #4

Merged
merged 1 commit into from Jan 20, 2018

Conversation

Projects
None yet
3 participants
@dburriss
Contributor

dburriss commented Dec 23, 2017

includes binary, pkaet.lock, etc. as discussed in comments.

@dustinmoris

This comment has been minimized.

Show comment
Hide comment
@dustinmoris

dustinmoris Dec 23, 2017

Member

Preferably the template...

Member

dustinmoris commented Dec 23, 2017

Preferably the template...

@dustinmoris

This comment has been minimized.

Show comment
Hide comment
@dustinmoris

dustinmoris Dec 24, 2017

Member

Really awesome work! Thank you so much, it really looks good and thanks for even extending the README with the new option (makes my life so easy :))! I had only a few minor questions which I commented above, but overall this looks very good so happy to merge as soon as you also think it's good to go.

Member

dustinmoris commented Dec 24, 2017

Really awesome work! Thank you so much, it really looks good and thanks for even extending the README with the new option (makes my life so easy :))! I had only a few minor questions which I commented above, but overall this looks very good so happy to merge as soon as you also think it's good to go.

@dustinmoris

This comment has been minimized.

Show comment
Hide comment
@dustinmoris

dustinmoris Dec 24, 2017

Member

Oh, one last question, did you say you included the paket.bootstrapper.exe and then renamed to paket.exe? Will this not cause a conflict when the real paket.exe will be downloaded?

Member

dustinmoris commented Dec 24, 2017

Oh, one last question, did you say you included the paket.bootstrapper.exe and then renamed to paket.exe? Will this not cause a conflict when the real paket.exe will be downloaded?

@dburriss

This comment has been minimized.

Show comment
Hide comment
@dburriss

dburriss Dec 24, 2017

Contributor

@dustinmoris WRT the rename, see step 3 here: http://fsprojects.github.io/Paket/getting-started.html#Downloading-Paket-s-Bootstrapper
It is part of the standard per repository setup for paket "magic mode"

Contributor

dburriss commented Dec 24, 2017

@dustinmoris WRT the rename, see step 3 here: http://fsprojects.github.io/Paket/getting-started.html#Downloading-Paket-s-Bootstrapper
It is part of the standard per repository setup for paket "magic mode"

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 24, 2017

forki commented Dec 24, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 24, 2017

Regarding paket.bootstrapper.exe. Yes please commit the 64kb as paket.exe - it will download real paket.exe to temp folder and redirect it to that tool automatically. That's the beauty of magic mode.

forki commented Dec 24, 2017

Regarding paket.bootstrapper.exe. Yes please commit the 64kb as paket.exe - it will download real paket.exe to temp folder and redirect it to that tool automatically. That's the beauty of magic mode.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 25, 2017

forki commented Dec 25, 2017

@dburriss

This comment has been minimized.

Show comment
Hide comment
@dburriss

dburriss Dec 27, 2017

Contributor

Referencing issue #1 that kicked off this PR

Contributor

dburriss commented Dec 27, 2017

Referencing issue #1 that kicked off this PR

@dburriss

This comment has been minimized.

Show comment
Hide comment
@dburriss

dburriss Jan 19, 2018

Contributor

@dustinmoris just wanted to make sure this isn't waiting on anything more from me?

Contributor

dburriss commented Jan 19, 2018

@dustinmoris just wanted to make sure this isn't waiting on anything more from me?

@dustinmoris

This comment has been minimized.

Show comment
Hide comment
@dustinmoris

dustinmoris Jan 19, 2018

Member

Hey, no sorry I haven't merged it yet for no particular reason to be honest. I thought I would have another version of Giraffe ready by now and then wanted to release a new version of the template with that new version of Giraffe + your new feature, but the work on Giraffe took me longer than anticipated and then this got a bit delayed. I am in a taxi to the airport now, so will merge this tomorrow latest! Sorry for the delay!

Member

dustinmoris commented Jan 19, 2018

Hey, no sorry I haven't merged it yet for no particular reason to be honest. I thought I would have another version of Giraffe ready by now and then wanted to release a new version of the template with that new version of Giraffe + your new feature, but the work on Giraffe took me longer than anticipated and then this got a bit delayed. I am in a taxi to the airport now, so will merge this tomorrow latest! Sorry for the delay!

@dburriss

This comment has been minimized.

Show comment
Hide comment
@dburriss

dburriss Jan 20, 2018

Contributor

No worries. I just wanted to make sure something wasn't waiting on me.

Contributor

dburriss commented Jan 20, 2018

No worries. I just wanted to make sure something wasn't waiting on me.

@dustinmoris

Fantastic work, thank you so much and sorry again for the delay!

@dustinmoris dustinmoris merged commit 69620ac into giraffe-fsharp:develop Jan 20, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment