Allow S3 credentials to be inferred by Boto #2229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2054
The easiest way to test this is to test creating an assetstore without credentials and without inferring, and then without credentials and with inferring, while tailing these logs:
When inferring you should see it doing the lookups in the log file:
I'm unsure of how exactly I should programmatically test this, seeing as how moto more or less ignores credentials entirely.
Sidenote: The Girder ansible-client has since gone out of date with the recent changes to S3 assetstores, I'll open a PR soon-ish bringing all of the arguments there up to date.