Set a maximum height for modal dialogs. #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a modal dialog is tall, the webpage as a whole gets a scrollbar and the dialog extends past the bottom. I think it looks better to have the dialog have a scroll bar (since the page may already be scrolled). The bootstrap css has different margins depending on window size; this makes one policy that is consistent.
|
I've done this in other girder-based applications and found it to work well. I'll let it sit for a while before approving. |
jbeezley
approved these changes
Dec 15, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a modal dialog is tall, the webpage as a whole gets a scrollbar and the dialog extends past the bottom. I think it looks better to have the dialog have a scroll bar (since the page may already be scrolled). The bootstrap css has different margins depending on window size; this makes one policy that is consistent.
This has the virtue that scrolling within the dialog doesn't affect the scroll position on the underlying main page.