Issue log message on upload #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for better log-based forensics for files uploaded into Girder.
manthey
reviewed
Jan 16, 2018
| @@ -243,6 +243,9 @@ def finalizeUpload(self, upload, assetstore=None): | |||
| if '_id' in upload: | |||
| self.remove(upload) | |||
|
|
|||
| logger.info('Upload complete. Upload=%s File=%s User=%s' % ( | |||
| upload['_id'], file['_id'], upload['userId'])) | |||
There was a problem hiding this comment.
Should we also add the size and/or the name of the file? When trying to determine files of interest, these could help.
There was a problem hiding this comment.
I didn't include any actual metadata about the file itself in the log, it seems more useful to just retain its ID and we could lookup the full metadata from the database via a script if needed.
Since much of the metadata is mutable, I figured we would be better off just using this as a way to do lookups into the database. Probably any analysis we'll want to perform will involve data munging from disparate sources.
manthey
approved these changes
Jan 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for better log-based forensics for files uploaded into Girder.