Refactor analysis, Add Wilcoxon, Add ANOVA #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgratzl
reviewed
Sep 17, 2019
subdavis
changed the title
…/metabulo into one-plot-pattern-to-rule-them-all
sgratzl
approved these changes
Sep 18, 2019
|
Forgot #227 would cause havoc here.... I'll rebase again. |
waxlamp
reviewed
Sep 18, 2019
There was a problem hiding this comment.
Overall this looks good to me. I left a whole bunch of comments to look over before merging, and as such I'm leaving this as a "comment" review rather than "approve" or "request changes", since I'm not really doing either of the latter. I will change to "approve" after even a quick review of my questions/comments.
…/metabulo into one-plot-pattern-to-rule-them-all
waxlamp
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to try and resolve the plot differences here.
#186, #181, #185 should close in favor of this PR.