From adf98dca02c04db1ebb0dc3d455ace0ff20c4469 Mon Sep 17 00:00:00 2001
From: Gisle Aas <gisle@aas.no>
Date: Wed, 29 Nov 2006 10:47:17 +0000
Subject: [PATCH] Release 1.08; don't put _ into dumped ints.

---
 Changes          | 19 +++++++++++++++++++
 lib/Data/Dump.pm | 13 +++----------
 t/dump.t         |  6 +++---
 3 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/Changes b/Changes
index 0f6be5c..5728e75 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,22 @@
+2006-11-29  Gisle Aas <gisle@ActiveState.com>
+
+   Release 1.08
+
+   By popular demand; don't put underscore into dumped integers
+   to group thousands.
+
+
+
+2006-11-24  Gisle Aas <gisle@ActiveState.com>
+
+   Release 1.07
+
+   Remove unused code.
+
+   Add some more tests.
+
+
+
 2004-11-12  Gisle Aas <gisle@ActiveState.com>
 
    Release 1.06
diff --git a/lib/Data/Dump.pm b/lib/Data/Dump.pm
index 1d3b93e..c493f62 100644
--- a/lib/Data/Dump.pm
+++ b/lib/Data/Dump.pm
@@ -7,7 +7,7 @@ require Exporter;
 *import = \&Exporter::import;
 @EXPORT_OK=qw(dump pp);
 
-$VERSION = "1.07";  # $Date$
+$VERSION = "1.08";  # $Date$
 $DEBUG = 0;
 
 use overload ();
@@ -181,15 +181,8 @@ sub _dump
 	    if (!defined $$rval) {
 		$out = "undef";
 	    }
-	    elsif ($$rval =~ /^-?[1-9]\d{0,8}$/ || $$rval eq "0") {
-		if (length $$rval > 4) {
-		    # Separate thousands by _ to make it more readable
-		    $out = reverse $$rval;
-		    $out =~ s/(\d\d\d)(?=\d)/$1_/g;
-		    $out = reverse $out;
-		} else {
-		    $out = $$rval;
-		}
+	    elsif ($$rval =~ /^-?[1-9]\d{0,9}$/ || $$rval eq "0") {
+		$out = $$rval;
 	    }
 	    else {
 		$out = quote($$rval);
diff --git a/t/dump.t b/t/dump.t
index efb7384..69cfc26 100644
--- a/t/dump.t
+++ b/t/dump.t
@@ -11,10 +11,10 @@ ok(dump("abc"), qq("abc"));
 ok(dump(undef), "undef");
 ok(dump(0), "0");
 ok(dump(1234), "1234");
-ok(dump(12345), "12_345");
-ok(dump(12345678), "12_345_678");
+ok(dump(12345), "12345");
+ok(dump(12345678), "12345678");
 ok(dump(-33), "-33");
-ok(dump(-123456), "-123_456");
+ok(dump(-1.5), "\"-1.5\"");
 ok(dump("0123"), qq("0123"));
 ok(dump(1..5), "(1, 2, 3, 4, 5)");
 ok(dump([1..5]), "[1, 2, 3, 4, 5]");