Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol ' possible in refname, so try define string with ''' #27

Closed
wants to merge 1 commit into from
Closed

Symbol ' possible in refname, so try define string with ''' #27

wants to merge 1 commit into from

Conversation

azarkevich
Copy link

Found couple refnames with symbol ' in name.
Proposed change solves problem in my repository, though I do not sure if it correct because I am not Python developer.

@esc
Copy link
Contributor

esc commented Oct 31, 2018

I'd be happy to merge this, if it doesn't break anything.

@esc
Copy link
Contributor

esc commented Nov 4, 2018

Can you rebase to master and add a test? Continuous integration is now active.

@hartwork hartwork added the bug label Dec 28, 2020
@esc
Copy link
Contributor

esc commented Dec 29, 2020

Pending on a reproducer and a test to expose the bug.

@hartwork
Copy link
Member

hartwork commented Jan 4, 2021

@azarkevich thanks for your bug report and patch contibution! I have cherry-picked your commit now, rebased onto latest master, and added a simple test in a new pull request #62.

@hartwork
Copy link
Member

hartwork commented Jan 5, 2021

Closing as superseded by #62

@hartwork hartwork closed this Jan 5, 2021
@hartwork hartwork self-assigned this Jan 7, 2021
hartwork added a commit that referenced this pull request Jan 7, 2021
…caping

Be robust with regard to branch names that contain tick characters ("'") (finishes up on #27)
@hartwork hartwork added this to the 1.0.0 milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants