Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception unstaging file via toolbar action #1178

Closed
lah7 opened this issue Oct 27, 2021 · 1 comment
Closed

Exception unstaging file via toolbar action #1178

lah7 opened this issue Oct 27, 2021 · 1 comment
Assignees
Labels

Comments

@lah7
Copy link
Contributor

lah7 commented Oct 27, 2021

Spotted a bug when trying to unstage a file via its toolbar action. Unstaging via the keyboard shortcut (CTRL+S) works and context menu is unaffected.

Steps to reproduce

  1. Add Unstage to a toolbar.
  2. Stage a file.
  3. Click Unstage on the toolbar.

Traceback

Traceback (most recent call last):

  File "/usr/lib/python3.9/site-packages/cola/cmds.py", line 2942, in do
    cmd = cls(*args, **opts)

  File "/usr/lib/python3.9/site-packages/cola/cmds.py", line 2693, in __init__
    staged = self.selection.staged

AttributeError: 'UnstageSelected' object has no attribute 'selection'
@davvid davvid self-assigned this Nov 7, 2021
@davvid davvid added the bug label Nov 7, 2021
@davvid davvid closed this as completed in bade8fd Nov 7, 2021
@davvid
Copy link
Member

davvid commented Nov 7, 2021

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants