Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
don't load very large files (or use mmap) #142
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
git-cola does follow the regular .gitignore rules; if you have binary files showing up then it's because they are not ignored.
We had some discussion about this on the list. I had disabled this feature at one point.
I think it'd be good to also guard against files that are too large, and add a tuning knob in case someone needs a threshold larger then 0.5MB (which is what I'd probably use as a default limit).
I'd also be tempted to use a QRunnable task to do it, but python's GIL will probably make the extra effort not worth it.