New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9.3 version does not work #221

Closed
ASKozienko opened this Issue Dec 22, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@ASKozienko

Since 1.9.3 version app does not want to start.

Traceback (most recent call last):
  File "./bin/git-cola", line 48, in <module>
    from cola import cmds
  File "/Users/username/Downloads/git-cola/cola/cmds.py", line 12, in <module>
    from cola import difftool
  File "/Users/username/Downloads/git-cola/cola/difftool.py", line 1, in <module>
    from PyQt4 import QtGui
ImportError: No module named PyQt4
@ASKozienko

This comment has been minimized.

Show comment
Hide comment
@ASKozienko

ASKozienko Dec 23, 2013

I know almost nothing about python and by this reason I dont want to fork project and open PR but next patch fixes issue. I hope this will be helpful for you.

diff --git a/bin/git-cola b/bin/git-cola
index 6b299f4..aecd02c 100755
--- a/bin/git-cola
+++ b/bin/git-cola
@@ -45,11 +45,10 @@ def setup_environment():
 setup_environment()

 from cola import core
-from cola import cmds
 from cola.app import add_common_arguments
 from cola.app import application_init
 from cola.app import application_start
-
+from cola import cmds

 def main():
     # we're using argparse with subparser, but argparse

I know almost nothing about python and by this reason I dont want to fork project and open PR but next patch fixes issue. I hope this will be helpful for you.

diff --git a/bin/git-cola b/bin/git-cola
index 6b299f4..aecd02c 100755
--- a/bin/git-cola
+++ b/bin/git-cola
@@ -45,11 +45,10 @@ def setup_environment():
 setup_environment()

 from cola import core
-from cola import cmds
 from cola.app import add_common_arguments
 from cola.app import application_init
 from cola.app import application_start
-
+from cola import cmds

 def main():
     # we're using argparse with subparser, but argparse

@ASKozienko ASKozienko closed this Dec 23, 2013

@ASKozienko ASKozienko reopened this Dec 23, 2013

@davvid davvid closed this in 0d50e4a Dec 24, 2013

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Dec 24, 2013

Member

My PyQt4 comes from the standard system location so I didn't notice this breakage on Mac OS X. Thanks for the report, that was totally helpful.

Member

davvid commented Dec 24, 2013

My PyQt4 comes from the standard system location so I didn't notice this breakage on Mac OS X. Thanks for the report, that was totally helpful.

@freemanoid

This comment has been minimized.

Show comment
Hide comment
@freemanoid

freemanoid Jan 29, 2014

👍
@davvid could you release a new version of git-cola with this fix so we can install it via homebrew?

👍
@davvid could you release a new version of git-cola with this fix so we can install it via homebrew?

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jan 31, 2014

Member

Okay, I'll do a release shortly. It's about that time ;-)

Member

davvid commented Jan 31, 2014

Okay, I'll do a release shortly. It's about that time ;-)

@davvid

This comment has been minimized.

Show comment
Hide comment
@freemanoid

This comment has been minimized.

Show comment
Hide comment

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment