New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum update does not support unicode files #234

Closed
ghost opened this Issue Feb 25, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Feb 25, 2014

Version 1.9.4

Traceback (most recent call last): 
  File "/usr/share/git-cola/lib/cola/widgets/main.py", line 604, in _update_callback 
    merge_msg_hash = utils.checksum(merge_msg_path) 
  File "/usr/share/git-cola/lib/cola/utils.py", line 264, in checksum 
    md5.update(core.read(path)) 
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 110: ordinal not in range(128)
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Feb 25, 2014

Member

Interesting. We just reworked the code to work with Python 3, and this code path was touched in the process (in other words, it may have been fixed).

Can you try cloning the repository down and seeing if the problem still exists there?

You can run out of the source tree like so (adjust ~/src/ as needed)

cd ~/src
git clone git://github.com/git-cola/git-cola.git
cd /to/your/repo/with/unicode
~/src/git-cola/bin/git-cola
Member

davvid commented Feb 25, 2014

Interesting. We just reworked the code to work with Python 3, and this code path was touched in the process (in other words, it may have been fixed).

Can you try cloning the repository down and seeing if the problem still exists there?

You can run out of the source tree like so (adjust ~/src/ as needed)

cd ~/src
git clone git://github.com/git-cola/git-cola.git
cd /to/your/repo/with/unicode
~/src/git-cola/bin/git-cola

davvid added a commit to davvid/git-cola that referenced this issue Feb 25, 2014

git: fix unicode error in non-ascii worktrees
Decode the worktree passed to set_worktree() so that we
maintain unicode purity in the internals.

Closes #234

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in fe9a317 Feb 25, 2014

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 26, 2014

2.0.0 is fixed. thank you!

ghost commented Feb 26, 2014

2.0.0 is fixed. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment