New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line breaking is not WYSIWYG #242

Closed
wm4 opened this Issue Mar 30, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@wm4

wm4 commented Mar 30, 2014

What you see in the git-cola commit message edit window is different from what ends up in the commit. For example, enter this into the edit window: resampler has been long removed. Our current resampler (libav/swresample) fd. In the edit window, the (libav/swresample) is on the first line, but if you commit it, it will be in the next line.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Apr 1, 2014

Member

In Preferences > Settings, what is the "text width" value? Is it 72 (default) or something else? I just tried this with text width = 72 and the display did match the commit for this line:

resampler has been long removed. Our current resampler (libav/swresample) fd

It word-wrapped before (libav/swresample). I entered this in the "Extended description" field. Did you do the same? We do our own word wrapping so that we can special-case things like Signed-off-by lines, but for this specific text it seems to wrap fine.

I'll try different text width settings to see if I can reproduce this. I would not be surprised to find a buglet in the word wrapping code. Maybe I can get Qt to do the wrapping for me (rather than writing my own function) then I'll know that it matches for sure. Thanks for the heads up.

Member

davvid commented Apr 1, 2014

In Preferences > Settings, what is the "text width" value? Is it 72 (default) or something else? I just tried this with text width = 72 and the display did match the commit for this line:

resampler has been long removed. Our current resampler (libav/swresample) fd

It word-wrapped before (libav/swresample). I entered this in the "Extended description" field. Did you do the same? We do our own word wrapping so that we can special-case things like Signed-off-by lines, but for this specific text it seems to wrap fine.

I'll try different text width settings to see if I can reproduce this. I would not be surprised to find a buglet in the word wrapping code. Maybe I can get Qt to do the wrapping for me (rather than writing my own function) then I'll know that it matches for sure. Thanks for the heads up.

@davvid davvid closed this in 4e0322b Apr 1, 2014

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Apr 1, 2014

Member

I found what I believe is the edge case. Thank you. Please let me know if this doesn't fix it.

Member

davvid commented Apr 1, 2014

I found what I believe is the edge case. Thank you. Please let me know if this doesn't fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment