New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after any dialog / window is closed: "wrapped C/C++ object of type GitBranchCompletionModel has been deleted" #346

Closed
alex-gulyas opened this Issue Sep 8, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@alex-gulyas
Contributor

alex-gulyas commented Sep 8, 2014

Every time I close a dialog (for example the Merge dialog), an error happens with the title "wrapped C/C++ object of type GitBranchCompletionModel has been deleted" with the following traceback:

File "/usr/share/git-cola/lib/cola/cmds.py", line 1564, in do_cmd
  return cmd.do()

File "/usr/share/git-cola/lib/cola/cmds.py", line 338, in do
  self.model.update_file_status()

File "/usr/share/git-cola/lib/cola/models/main.py", line 178, in update_file_status
  self.notify_observers(self.message_updated)

File "/usr/share/git-cola/lib/cola/observable.py", line 28, in notify_observers
  method(*args, **opts)

File "/usr/share/git-cola/lib/cola/widgets/completion.py", line 400, in emit_update
  self.emit(SIGNAL('update()'))

RuntimeError: wrapped C/C++ object of type GitBranchCompletionModel has been deleted
  • Arch Linux x64
  • Python 2.7.8 & 3.4.1
  • Qt 4.8.6
  • pyqt 4.11.1
  • git-cola 2.0.6
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Sep 9, 2014

Member

Hi, would you mind cloning the repo and running out of the source tree?

I thought this was addressed in 972a73b, which should be in v2.0.6, so I just want to make sure that it hasn't already been addressed. I could go back to hook into __del__ as well for safety.

Interestingly, the PyQt versions I'm using don't have this problem (slightly older versions) so that may be related. I've tested on 4.6.2 and 4.10.x.

Update: if the current code is broken, I wonder whether the commit referenced above actually made things better for some versions but broke others. One way to know would be to checkout v2.0.5 and see if that one is better behaved. If it is, then I may be able to rework the fix so that it works across both versions. Let me know

Member

davvid commented Sep 9, 2014

Hi, would you mind cloning the repo and running out of the source tree?

I thought this was addressed in 972a73b, which should be in v2.0.6, so I just want to make sure that it hasn't already been addressed. I could go back to hook into __del__ as well for safety.

Interestingly, the PyQt versions I'm using don't have this problem (slightly older versions) so that may be related. I've tested on 4.6.2 and 4.10.x.

Update: if the current code is broken, I wonder whether the commit referenced above actually made things better for some versions but broke others. One way to know would be to checkout v2.0.5 and see if that one is better behaved. If it is, then I may be able to rework the fix so that it works across both versions. Let me know

@alex-gulyas

This comment has been minimized.

Show comment
Hide comment
@alex-gulyas

alex-gulyas Sep 10, 2014

Contributor

I haven't used git-cola since I opened this issue, but when I tried it today it didn't show the error.
Looking up the update history, I didn't find any python related update in the last few days, so it is unlikely that an update fixed it.

The source code I used was the v2.0.6.zip downloaded from the releases section, and it did contain the mentioned commit (I manually checked the source code to be sure). I also cloned and checked 2.0.5 and it was working fine.

As I can't reproduce it anymore, I believe it was a glitch in my PC, and not a bug in git-cola.

I think this issue can be closed, unless others complain about this too.

Contributor

alex-gulyas commented Sep 10, 2014

I haven't used git-cola since I opened this issue, but when I tried it today it didn't show the error.
Looking up the update history, I didn't find any python related update in the last few days, so it is unlikely that an update fixed it.

The source code I used was the v2.0.6.zip downloaded from the releases section, and it did contain the mentioned commit (I manually checked the source code to be sure). I also cloned and checked 2.0.5 and it was working fine.

As I can't reproduce it anymore, I believe it was a glitch in my PC, and not a bug in git-cola.

I think this issue can be closed, unless others complain about this too.

@davvid davvid closed this in aca1760 Sep 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment