Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Error after any dialog / window is closed: "wrapped C/C++ object of type GitBranchCompletionModel has been deleted" #346
Every time I close a dialog (for example the Merge dialog), an error happens with the title "wrapped C/C++ object of type GitBranchCompletionModel has been deleted" with the following traceback:
Hi, would you mind cloning the repo and running out of the source tree?
I thought this was addressed in 972a73b, which should be in v2.0.6, so I just want to make sure that it hasn't already been addressed. I could go back to hook into
Interestingly, the PyQt versions I'm using don't have this problem (slightly older versions) so that may be related. I've tested on 4.6.2 and 4.10.x.
Update: if the current code is broken, I wonder whether the commit referenced above actually made things better for some versions but broke others. One way to know would be to checkout v2.0.5 and see if that one is better behaved. If it is, then I may be able to rework the fix so that it works across both versions. Let me know
I haven't used git-cola since I opened this issue, but when I tried it today it didn't show the error.
The source code I used was the v2.0.6.zip downloaded from the releases section, and it did contain the mentioned commit (I manually checked the source code to be sure). I also cloned and checked 2.0.5 and it was working fine.
As I can't reproduce it anymore, I believe it was a glitch in my PC, and not a bug in git-cola.
I think this issue can be closed, unless others complain about this too.