New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows, file notification causes dag to refresh all the time #480

Closed
sthalik opened this Issue Jul 24, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@sthalik
Contributor

sthalik commented Jul 24, 2015

With pywin32 installed for notification support, building with "make -j4" causes dag to relaunch git, refill the commit list and reset the selected line position back to the first commit.

Note, the build directory is ignored by .gitignore and none of the files in it are tracked by git.

@davvid davvid closed this in 9433344 Jul 25, 2015

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jul 25, 2015

Member

I made it so that we remember and restore the selection, but it sounds like maybe we can improve things some more. This was not a windows-specific issue (the selection part, at least).

It's curious that you noted that all of your files are .gitignored. I do not observe that behavior on linux. @kbielefe any thoughts?

Member

davvid commented Jul 25, 2015

I made it so that we remember and restore the selection, but it sounds like maybe we can improve things some more. This was not a windows-specific issue (the selection part, at least).

It's curious that you noted that all of your files are .gitignored. I do not observe that behavior on linux. @kbielefe any thoughts?

@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik Jul 26, 2015

Contributor

Sadly this doesn't work. The list becomes empty for split second, then newest commit becomes active.

Contributor

sthalik commented Jul 26, 2015

Sadly this doesn't work. The list becomes empty for split second, then newest commit becomes active.

davvid added a commit that referenced this issue Jul 26, 2015

dag: improve selection restoration behavior
Ensure that the selection is saved (and not clobbered when it becomes
empty) so that we can properly restore the selection across refreshes.

Related-to: #480
Signed-off-by: David Aguilar <davvid@gmail.com>
@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik Jul 27, 2015

Contributor

Other than the flicker and #477 (Popen doesn't hide window) it works, thanks!

Contributor

sthalik commented Jul 27, 2015

Other than the flicker and #477 (Popen doesn't hide window) it works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment