New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dag flashes again when building in ignored subdirectory #620

Closed
sthalik opened this Issue Nov 3, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@sthalik
Contributor

sthalik commented Nov 3, 2016

It didn't happen before merging @living180's branch. Shortly after it did and I fail to find the breaking commit. Try merely adding ignored files and see how dag refreshes.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Nov 5, 2016

Member

Hmm are you running on Windows or Linux? The filesystem monitoring implementation is unique to each one. I don't observe this behavior on Linux so I'm going to assume that this problem only exists in the Windows filesystem notifier. Please let me know if this is not the case.

I did manage to get a slightly newer Windows environment setup so I'll try to take a look next week (unless someone beats me to it). If this fix is nice and simple then I'd like to include it as the last topic that gets merged in before the upcoming v2.9 release.

Member

davvid commented Nov 5, 2016

Hmm are you running on Windows or Linux? The filesystem monitoring implementation is unique to each one. I don't observe this behavior on Linux so I'm going to assume that this problem only exists in the Windows filesystem notifier. Please let me know if this is not the case.

I did manage to get a slightly newer Windows environment setup so I'll try to take a look next week (unless someone beats me to it). If this fix is nice and simple then I'd like to include it as the last topic that gets merged in before the upcoming v2.9 release.

@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik Nov 6, 2016

Contributor

This is Windows.

Contributor

sthalik commented Nov 6, 2016

This is Windows.

@living180

This comment has been minimized.

Show comment
Hide comment
@living180

living180 Nov 15, 2016

Contributor

@sthalik -I just did some basic testing of this and am not able to reproduce it on Windows. I tried both git-cola and git-dag against a git checkout of git-cola itself. Touching a file tracked by git (e.g. a .py file) caused a refresh, but touching an ignored file (e.g. a .pyc file) did not. Creating a file an an ignored directory (e.g. in test/tmp) also did not cause a refresh.

I'm happy to look into this some more, but I'll need more information on how to reproduce what you are seeing.

Contributor

living180 commented Nov 15, 2016

@sthalik -I just did some basic testing of this and am not able to reproduce it on Windows. I tried both git-cola and git-dag against a git checkout of git-cola itself. Touching a file tracked by git (e.g. a .py file) caused a refresh, but touching an ignored file (e.g. a .pyc file) did not. Creating a file an an ignored directory (e.g. in test/tmp) also did not cause a refresh.

I'm happy to look into this some more, but I'll need more information on how to reproduce what you are seeing.

@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik May 6, 2017

Contributor

@living180 it persists when building. It doesn't matter if I ignore /build*/ or put * in build directory's .gitignore. All the build directory files are untracked. How can I help you reproduce this case?

Contributor

sthalik commented May 6, 2017

@living180 it persists when building. It doesn't matter if I ignore /build*/ or put * in build directory's .gitignore. All the build directory files are untracked. How can I help you reproduce this case?

@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik May 6, 2017

Contributor

FWIW the project builds with MS Visual C++ 2015 and newer and can be built using precompiled official Qt 5.

I forgot all this time -- the partition the project is on is ReFS, not NTFS. I keep all heavy storage out of NTFS.

Contributor

sthalik commented May 6, 2017

FWIW the project builds with MS Visual C++ 2015 and newer and can be built using precompiled official Qt 5.

I forgot all this time -- the partition the project is on is ReFS, not NTFS. I keep all heavy storage out of NTFS.

@living180

This comment has been minimized.

Show comment
Hide comment
@living180

living180 May 17, 2017

Contributor

@sthalik sorry for the delay in getting back with you. At this point, I might have to create a branch with some extra instrumentation for you to run to help determine what is going on. If that is acceptable, can you tell me what version of git-cola you normally run (e.g. git master, v2.11, etc.) and I'll create a new branch based on that.

Contributor

living180 commented May 17, 2017

@sthalik sorry for the delay in getting back with you. At this point, I might have to create a branch with some extra instrumentation for you to run to help determine what is going on. If that is acceptable, can you tell me what version of git-cola you normally run (e.g. git master, v2.11, etc.) and I'll create a new branch based on that.

@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik May 17, 2017

Contributor

@living180 I'm using master. Thanks.

Contributor

sthalik commented May 17, 2017

@living180 I'm using master. Thanks.

davvid added a commit to davvid/git-cola that referenced this issue Sep 5, 2017

doc/relnotes/v3.0: mention git-cola#620 and git-cola#724 in the relea…
…se notes

Add a blurb about the improved DAG refresh behavior.

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in bdc609f Sep 5, 2017

@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik Sep 5, 2017

Contributor

Works. Thanks!

Contributor

sthalik commented Sep 5, 2017

Works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment