New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On MacOS the toolbars are displayed pitch black. #624

Closed
utkukaratas opened this Issue Nov 11, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@utkukaratas

utkukaratas commented Nov 11, 2016

On MacOS the toolbars are displayed pitch black.

Tested on El Capitan. Happens in all the windows: the DAG viewer and main app.

screen shot 2016-11-12 at 12 18 48 am 1

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Nov 12, 2016

Member

thanks for the heads-up. please try the macos-toolbars branch in my fork https://github.com/davvid/git-cola/tree/macos-toolbars

does it fix the issue for you? I can't reproduce the problem myself on El Cap (seems to work fine here) but the change did fix a long-standing bug where the toolbars would display with a transparent background when detached. I have a feeling that the change may have also fixed this issue.

Let me know if it helps.

Member

davvid commented Nov 12, 2016

thanks for the heads-up. please try the macos-toolbars branch in my fork https://github.com/davvid/git-cola/tree/macos-toolbars

does it fix the issue for you? I can't reproduce the problem myself on El Cap (seems to work fine here) but the change did fix a long-standing bug where the toolbars would display with a transparent background when detached. I have a feeling that the change may have also fixed this issue.

Let me know if it helps.

@utkukaratas

This comment has been minimized.

Show comment
Hide comment
@utkukaratas

utkukaratas Nov 12, 2016

This does fix the issue. Thanks.

Although, I just checked out master and that also does fix the issue. So I'm guessing this issue is particular to the vanilla homebrew install.

utkukaratas commented Nov 12, 2016

This does fix the issue. Thanks.

Although, I just checked out master and that also does fix the issue. So I'm guessing this issue is particular to the vanilla homebrew install.

@davvid davvid closed this in a3f13fe Nov 14, 2016

@raimue

This comment has been minimized.

Show comment
Hide comment
@raimue

raimue Nov 14, 2016

Contributor

This issue only appeared for me on macOS 10.12 Sierra when using Qt5, the toolbars are fine with Qt4. Note qtpy will always prefer Qt5 unless you export QT_API=pyqt4 in the environment before running git-cola. This might be a workaround for others as well.

Contributor

raimue commented Nov 14, 2016

This issue only appeared for me on macOS 10.12 Sierra when using Qt5, the toolbars are fine with Qt4. Note qtpy will always prefer Qt5 unless you export QT_API=pyqt4 in the environment before running git-cola. This might be a workaround for others as well.

@zjx20

This comment has been minimized.

Show comment
Hide comment
@zjx20

zjx20 Jan 3, 2017

@davvid There are still some views have a black background color, could you please take a look? Actually, I suspect the black color is the default background color for all views.

OS: macOS 10.12.1
git-cola version: 2.9.1_1 (installed via brew)

Here are a few of them:

The parent view of the commit summary text view:
780484d2-4584-4cdc-869e-38a79d660b52

The stash view:
ba591b08-9457-4760-a9ba-c9638984e6f9

zjx20 commented Jan 3, 2017

@davvid There are still some views have a black background color, could you please take a look? Actually, I suspect the black color is the default background color for all views.

OS: macOS 10.12.1
git-cola version: 2.9.1_1 (installed via brew)

Here are a few of them:

The parent view of the commit summary text view:
780484d2-4584-4cdc-869e-38a79d660b52

The stash view:
ba591b08-9457-4760-a9ba-c9638984e6f9

@davvid davvid reopened this Jan 3, 2017

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jan 3, 2017

Member

I fixed the main screen and will take a look at fixing the rest shortly. Some defaults changed in PyQt5/MacOS

Member

davvid commented Jan 3, 2017

I fixed the main screen and will take a look at fixing the rest shortly. Some defaults changed in PyQt5/MacOS

@davvid davvid closed this in 3ab33a4 Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment