New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu mouse issue. #643

Closed
Parashurama opened this Issue Jan 7, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@Parashurama

Parashurama commented Jan 7, 2017

First, this is likely not a purely git-cola issue, as this also appear in an other qt application (qgit).
In git-cola with when right-clicking on an item in status or diff panel, and not releasing immediately the button, I can accidentally select the first entry of the context menu.
This is really annoying in the diff section since the first entry is 'stage the whole modified file'.
The issue appear in python 2.7/3.5 and using PyQt4.8/PyQt5.5

An easy way to solve my issue (and for others, I assume) would be to nudge the context menu position by 2~3 pixels in every contextMenuEvent function.

    def contextMenuEvent(self, event):
        ...
        menu.exec_(self.mapToGlobal(event.pos()))

into

    def contextMenuEvent(self, event):
        ...
        ev_pos = event.pos(); ev_pos.setX(ev_pos.x() + CONTEXT_MENU_NUDGE)
        menu.exec_(self.mapToGlobal(event.pos()))

I will write a proper pull request in a few days, if this is acceptable.

@davvid

This comment has been minimized.

Member

davvid commented Jan 8, 2017

I've ran into that a few times myself as well. 👍

@Vdragon

This comment has been minimized.

Contributor

Vdragon commented Jan 8, 2017

Thanks for filing it, sounds more like a bug

@rpost

This comment has been minimized.

Contributor

rpost commented Dec 4, 2017

Since more than a few days passed already I decided to take action: please find corresponding pr. I took different path to solve this issue though: instead of moving menu few pixels (which I tried as well, but found akward), I introduced short period of insensitivity right after menu was created.

davvid added a commit to davvid/git-cola that referenced this issue Dec 4, 2017

Merge pull request git-cola#755 from rpost/issue-643
* rpost/issue-643:
  widgets: disable annoying context menu behaviour

Closes git-cola#643
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in #755 Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment