Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid localized timestamp in Console widget #817

Closed
brlin-tw opened this issue May 9, 2018 · 3 comments
Closed

Avoid localized timestamp in Console widget #817

brlin-tw opened this issue May 9, 2018 · 3 comments

Comments

@brlin-tw
Copy link
Contributor

brlin-tw commented May 9, 2018

screenshot_20180509_235923

It takes too much space and has no benefit, simple YYYY/MM/DD HH/MM/SS: will be enough.

@davvid
Copy link
Member

davvid commented May 11, 2018

@alex-gulyas any thoughts?

@alex-gulyas
Copy link
Contributor

@davvid: I think we have 3 options:

  1. Use the users locale
    The whole point of locales is that apps can display information in a way that is natural to the users. I strongly believe that this is the better choice, unless you don't mind implementing option 3.
  2. Use a hard coded format
    There are a lot of different ways to format dates/times, so there is no single format that will please everyone. If this option is selected, then I highly suggest to use an international standard format, like ISO 8601: %Y-%m-%d %H:%M:%S (2018-05-09 23:58:13).
  3. Make it user configurable
    This might be overkill, but this would resolve date/time formatting related issues once and for all. (The default format should be the localized one.)

@Lin-Buo-Ren:

  • Your suggested format would reduce the width of the date/time format by 6 characters (6 double width chars -> 6 single width chars). But as soon as git starts to print out paths and other messages, the lines would have to be wrapped anyway. Maybe increase the width of the console widget (or redock it to make it full width within the app window)?
  • On Linux (sorry, I'm not familiar with other systems) there is a way to force a different locale to a specific application.

@davvid davvid closed this as completed in 7ed05d7 May 17, 2018
@davvid
Copy link
Member

davvid commented May 17, 2018

ISO-8601 really makes a lot of sense here. Thanks for the sug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants