Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing regression test #993

Closed
bket opened this issue Sep 23, 2019 · 1 comment
Closed

Failing regression test #993

bket opened this issue Sep 23, 2019 · 1 comment

Comments

@bket
Copy link

@bket bket commented Sep 23, 2019

On OpenBSD I experience a failing test with git-cola 3.5. This failure is not observed with 3.4.

=================================== FAILURES ===================================
___________________ IconTestCase.test_from_filename_unicode ____________________

self = <test.icons_test.IconTestCase testMethod=test_from_filename_unicode>

    def test_from_filename_unicode(self):
        filename = compat.uchr(0x400) + '.odt'
        expect = 'file-code.svg'
        actual = icons.basename_from_filename(filename)
>       self.assertEqual(expect, actual)
E       AssertionError: u'file-code.svg' != u'file-text.svg'
E       - file-code.svg
E       ?      ^^^
E       + file-text.svg
E       ?      ^ ++

../icons_test.py:17: AssertionError
1 failed, 166 passed in 15.36 seconds

Any idea where to look?

@davvid

This comment has been minimized.

Copy link
Member

@davvid davvid commented Sep 25, 2019

Hmm it could be related to mimetypes. We might have some code where we check the mime type for the xxx.odt filename and it's giving a different result on openbsd.

That test should probably be tweaked to not be platform-dependent, maybe by choosing a more stable extension such as .txt. Thanks for the heads-up. That should be a harmless failure.

@davvid davvid closed this in f1cff6f Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.