Don't pass shell=True to core.run_command() #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the Git.execute() method was passing shell=True to the core.run_command() function. This was to avoid a console window briefly popping up on the screen each time git-cola invoked git, which could happen if git-cola was invoked using "start pythonw git-cola". But, using shell=True is generally undesirable. This change stops passing shell=True and instead creates a STARTUPINFO structure and configures it to ensure that any child process window is hidden. Because the Windows shell is no longer being invoked, the replace_carot function is no longer needed and is removed. Signed-off-by: Daniel Harding <dharding@living180.net>
|
Nicely done. 👍 |
davvid
added a commit
that referenced
this pull request
May 9, 2014
Don't pass shell=True to core.run_command()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the
Git.execute()method was passingshell=Trueto thecore.run_command()function. This was to avoid a console window briefly popping up on the screen each time git-cola invoked git, which could happen if git-cola was invoked usingstart pythonw git-cola. But, usingshell=Trueis generally undesirable. This change stops passingshell=Trueand instead creates aSTARTUPINFOstructure and configures it to ensure that any child process window is hidden.Because the Windows shell is no longer being invoked, the
replace_carotfunction is no longer needed and is removed.