New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure Git subprocess spawns no window on win32 #486

Merged
merged 1 commit into from Aug 14, 2015

Conversation

Projects
None yet
3 participants
@sthalik
Contributor

sthalik commented Aug 11, 2015

There's an additional Popen flag that needs specifying, as per commit.

Fixes #477

@living180

This comment has been minimized.

Show comment
Hide comment
@living180

living180 Aug 11, 2015

Contributor

+1

Contributor

living180 commented Aug 11, 2015

+1

davvid added a commit that referenced this pull request Aug 12, 2015

textwrap: add more special tags
Do not word-wrap "Link:", "References:", "Related-to:", and "See-also:"
trailers in the commit message, as they often contain long URLs.

Related-to: #486
Signed-off-by: David Aguilar <davvid@gmail.com>
ensure Git subprocess spawns no window on win32
Specifying SW_HIDE isn't enough, it's also necessary to pass
CREATE_NO_WINDOW "creation flag".

MSDN: <https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396>

v2: Set creationflags conditionally on win32 only to make the code
easier to understand. Suggested by David Aguilar.

Signed-off-by: Stanislaw Halik <sthalik@misaki.pl>
@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik Aug 13, 2015

Contributor

@davvid I agree conditional "creationflags" makes the code less messy, even though it's used only for win32. I've adjusted the wraparound with $EDITOR. Maybe long single-words could be always not broken?

Contributor

sthalik commented Aug 13, 2015

@davvid I agree conditional "creationflags" makes the code less messy, even though it's used only for win32. I've adjusted the wraparound with $EDITOR. Maybe long single-words could be always not broken?

davvid added a commit that referenced this pull request Aug 14, 2015

Merge pull request #486 from sthalik/win32-flashing-git-window
core: ensure Git subprocess spawns no window on win32

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit 467d4a0 into git-cola:master Aug 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sthalik sthalik deleted the sthalik:win32-flashing-git-window branch Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment