New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auto-reset of "Bypass Commit Hooks" setting #595

Merged
merged 1 commit into from Sep 8, 2016

Conversation

Projects
None yet
2 participants
@AndiDog
Contributor

AndiDog commented Sep 6, 2016

This feature is typically used in exceptional cases (e.g. commit something that I will not push unchanged), so my usual workflow is to reset the flag immediately after using it. Add a configuration for auto-resetting that flag.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Sep 7, 2016

Member

The Bypass Commit Hooks setting definitely does seem like a one-off use setting, similar to the Amend mode that clears itself as soon as a commit is made.

I'm slightly in favor of making this the default behavior, and not have a configuration option for it at all.

IMO, if someone needs to keep disabling their commit hook then they can just as easily disable it completely at the repository level. From that perspective, the code that disables the Bypass Commit Hooks option should always run.

What do you think?

Member

davvid commented Sep 7, 2016

The Bypass Commit Hooks setting definitely does seem like a one-off use setting, similar to the Amend mode that clears itself as soon as a commit is made.

I'm slightly in favor of making this the default behavior, and not have a configuration option for it at all.

IMO, if someone needs to keep disabling their commit hook then they can just as easily disable it completely at the repository level. From that perspective, the code that disables the Bypass Commit Hooks option should always run.

What do you think?

@AndiDog

This comment has been minimized.

Show comment
Hide comment
@AndiDog

AndiDog Sep 7, 2016

Contributor

I'm actually of the same opinion, but just made it backward compatible since I thought that's the usual way. Ok, then please wait until I've adapted to make it the default without configuration.

Contributor

AndiDog commented Sep 7, 2016

I'm actually of the same opinion, but just made it backward compatible since I thought that's the usual way. Ok, then please wait until I've adapted to make it the default without configuration.

commitmsg: auto-reset "Bypass Commit Hooks" setting on commit
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
@AndiDog

This comment has been minimized.

Show comment
Hide comment
@AndiDog

AndiDog Sep 7, 2016

Contributor

Done, now it's a really simple one line change ;)

Contributor

AndiDog commented Sep 7, 2016

Done, now it's a really simple one line change ;)

@davvid davvid merged commit e4ef3ff into git-cola:master Sep 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

davvid added a commit that referenced this pull request Sep 8, 2016

doc: update v2.9 release notes draft to mention PR #595
Signed-off-by: David Aguilar <davvid@gmail.com>

@AndiDog AndiDog deleted the AndiDog:feature/auto-reset-bypass-commit-hooks branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment