commitmsg: keep spellcheck selection after exit #645

Merged
merged 1 commit into from Jan 18, 2017

Conversation

Projects
None yet
3 participants
@judaszszymon
Contributor

judaszszymon commented Jan 15, 2017

The spellcheck setting was stored in checkbox and reseted after program exit.
The setting is now stored via gitcfg and retrieved after program startup.
Also, add another spellcheck checkbox in preferences window.

Motivation: #596 #632

Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl

commitmsg: keep spellcheck selection after exit
The spellcheck setting was stored in checkbox and reseted after program exit.
The setting is now stored via gitcfg and retrieved after program startup.
Also, adds another spellcheck checkbox in preferences window.

Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl
@davvid

Looks good otherwise, I'll merge and fixup the file locally.

@@ -638,4 +651,4 @@ def keyPressEvent(self, event):
def setFont(self, font):
SpellCheckTextEdit.setFont(self, font)
fm = self.fontMetrics()
- self.setMinimumSize(QtCore.QSize(1, fm.height() * 2))
+ self.setMinimumSize(QtCore.QSize(1, fm.height() * 2))

This comment has been minimized.

@davvid

davvid Jan 18, 2017

Member

This file now has "no newline at end of file". Are you using sublime text?

https://forum.sublimetext.com/t/make-saving-newline-at-eof-the-installation-default/9842

@davvid

davvid Jan 18, 2017

Member

This file now has "no newline at end of file". Are you using sublime text?

https://forum.sublimetext.com/t/make-saving-newline-at-eof-the-installation-default/9842

@davvid davvid merged commit 8bb9f33 into git-cola:master Jan 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

davvid added a commit that referenced this pull request Jan 18, 2017

Merge pull request #645 from judaszszymon/test
* judaszszymon/test:
  commitmsg: keep spellcheck selection after exit

Signed-off-by: David Aguilar <davvid@gmail.com>
@judaszszymon

This comment has been minimized.

Show comment
Hide comment
@judaszszymon

judaszszymon Jan 18, 2017

Contributor

@davvid thanks for info 👍, i completely missed that

Contributor

judaszszymon commented Jan 18, 2017

@davvid thanks for info 👍, i completely missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment