New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch: add filter widget #713

Merged
merged 2 commits into from Jul 29, 2017

Conversation

Projects
None yet
2 participants
@javierrodriguezcuevas
Contributor

javierrodriguezcuevas commented Jul 19, 2017

Hi!
This is a simple filter that hightlight the branches containing the text on it.

Signed-off-by: javierrodriguezcuevas javierrodriguezcuevas@gmail.com

branch: add filter widget
Signed-off-by: javierrodriguezcuevas <javierrodriguezcuevas@gmail.com>
@davvid

On my setup (dark background) this looks messed up because only the background is set, and it's setting a light background onto a light-colored foreground font.

I think it would be better to choose the Highlight color for the background and also set the HighlightText to the foreground. That way we don't end up with a mismatch.

That said, the highlighting is a little intense. How about, instead of changing the palette, make the text bold instead? If that's too subtle then the palette should do the trick too. Looks good otherwise!

@javierrodriguezcuevas

This comment has been minimized.

Show comment
Hide comment
@javierrodriguezcuevas

javierrodriguezcuevas Jul 28, 2017

Contributor

I discarded the use of 'Highlight' because in my case it is the same color as when I select a branch. Making the name of the branch bold seems even better than using the color palette for me. I Will make the change this weekend.

Contributor

javierrodriguezcuevas commented Jul 28, 2017

I discarded the use of 'Highlight' because in my case it is the same color as when I select a branch. Making the name of the branch bold seems even better than using the color palette for me. I Will make the change this weekend.

branch: applying bold text to filtered branches
Signed-off-by: javierrodriguezcuevas <javierrodriguezcuevas@gmail.com>
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jul 29, 2017

Member

Awesome

Member

davvid commented Jul 29, 2017

Awesome

davvid added a commit to davvid/git-cola that referenced this pull request Jul 29, 2017

Merge pull request git-cola#713 from javierrodriguezcuevas/feature/br…
…anches_filter

* javierrodriguezcuevas/feature/branches_filter:
  branch: applying bold text to filtered branches
  branch: add filter widget

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit d21b7e8 into git-cola:master Jul 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment