New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup GitDialog input focus #804

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@laerreal
Contributor

laerreal commented Apr 17, 2018

I faced a buggy behaviour of GitDialog (GitBranchDialog in particular).

Sequence to reproduce:

  1. press Alt and B
  2. release them after the branch dialog showed
  3. press some buttons to input a branch name (for instance, m, a, s, t, e, r)

Expected result: the branch name (master) was entered.
Actual result: only first character (m) was entered.
Environment: Ubuntu Linux 16.04 amd64, GNOME Flashback desktop env., Compiz window mgr.

This bug is not appears if the branch dialog is opened using menu.
Adding a short delay before auto completion popup showing fixes it.

GitDialog: add delay before completion popup showing
This fixes buggy behavior of ?LineEdit widget input

Signed-off-by: Efimov Vasily <real@ispras.ru>

davvid added a commit to davvid/git-cola that referenced this pull request Apr 18, 2018

Merge pull request git-cola#804 from laerreal/fixup_gitdialog_focus
* laerreal/fixup_gitdialog_focus:
  GitDialog: add delay before completion popup showing

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit 86b6822 into git-cola:master Apr 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment