Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: hide current repo from "Open Recent" menu #998

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@stimut
Copy link
Contributor

stimut commented Oct 14, 2019

The current repo was showing up in the "Open Recent" menu, which serves
no purpose.

Now the current repo is not shown, with the current repo determined from
the path.

Closes #983
Signed-off-by: Tim Brown stimut@gmail.com

The current repo was showing up in the "Open Recent" menu, which serves
no purpose.

Now the current repo is not shown, with the current repo determined from
the path.

Signed-off-by: Tim Brown <stimut@gmail.com>
@stimut stimut force-pushed the stimut:hide-current-repo-in-recent-list branch from 7e997a1 to 6dbabaa Oct 14, 2019
@davvid
davvid approved these changes Oct 15, 2019
Copy link
Member

davvid left a comment

Good idea.

Small tweaks -- self.git.worktree() is a loop invariant so we can calculate it outside of the entry loop. We can keep the indentation flatter and minimize the diff by doing,

if directory == worktree:
    continue

.. instead of indenting the guts further. This was tweaked post-merge. Thanks.

davvid added a commit that referenced this pull request Oct 15, 2019
* stimut/hide-current-repo-in-recent-list:
  main: hide current repo from "Open Recent" menu

Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid merged commit 6dbabaa into git-cola:master Oct 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stimut stimut deleted the stimut:hide-current-repo-in-recent-list branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.