Skip to content

Conversation

@kwin
Copy link

@kwin kwin commented Mar 9, 2015

fixes #108 by only overwriting properties which are set by the maven-git-commit-id-plugin. Also disables the propagation of properties by default.

@ktoso
Copy link
Collaborator

ktoso commented Mar 9, 2015

Thanks, great contrib! I agree with your findings and the fix, thanks again.

ktoso added a commit that referenced this pull request Mar 9, 2015
only propagate git properties to other maven modules
@ktoso ktoso merged commit 8fc9e1e into git-commit-id:master Mar 9, 2015
@ktoso ktoso added this to the 2.1.13 milestone Mar 10, 2015
@TheSnoozer TheSnoozer changed the title only propagate git properties to other maven modules fixes #108: only propagate git properties to other maven modules Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

injectAllReactorProjects overwrites non-git properties in reactor projects

2 participants