Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add an option to normalize sync hooks #1

Open
avar opened this Issue Jan 31, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Owner

avar commented Jan 31, 2012

Currently we have sync hooks in their own directory, they should follow the same pattern as the other hooks, which should live in the top-level hook directory.

We should probably introduce a config option for this to do this in a backwards compatible way.

Owner

avar commented Feb 1, 2012

It would also be nice if you could have /sync.* hooks just like all the other hooks, so you could have more than one.

If they fail we would just instruct the user to run:

(
     hook-1 &&
     hook-2
 )

etc. instead of the single named hook we have now.

Better yet, provide a:

git-deploy --run-sync-hook
Owner

demerphq commented Feb 1, 2012

I have no problem if we normalize the hooks. I think we should think carefully about how it is done. The earliest hooks were over-engineered, but i think maybe the new ones are under-engineered. It would be good to have a normalized structure that is in the sweet spot in between.

hooks/$app/$hook/*
hooks/$hook/$app/*

maybe? If we support multiple scripts per hook we have to define their semantics well.

We also have to think about hooks that should return information to git-deploy instead of performing an action under its control. So then maybe

 hooks/$app/$hook

is better after all. I am undecided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment