Navigation Menu

Skip to content

Commit

Permalink
Always auto-gc after calling a fast-import transport
Browse files Browse the repository at this point in the history
After importing anything with fast-import, we should always let the
garbage collector do its job, since the objects are written to disk
inefficiently.

This brings down an initial import of http://selenic.com/hg from about
230 megabytes to about 14.

In the future, we may want to make this configurable on a per-remote
basis, or maybe teach fast-import about it in the first place.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Jan 18, 2017
1 parent 7a99896 commit 3e81be1
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions transport-helper.c
Expand Up @@ -13,6 +13,8 @@
#include "refs.h"

static int debug;
/* TODO: put somewhere sensible, e.g. git_transport_options? */
static int auto_gc = 1;

struct helper_data {
const char *name;
Expand Down Expand Up @@ -561,6 +563,12 @@ static int fetch_with_import(struct transport *transport,
}
}
strbuf_release(&buf);
if (auto_gc) {
const char *argv_gc_auto[] = {
"gc", "--auto", "--quiet", NULL,
};
run_command_v_opt(argv_gc_auto, RUN_GIT_CMD);
}
return 0;
}

Expand Down

0 comments on commit 3e81be1

Please sign in to comment.