Skip to content


Merge pull request #2315 from ROGERSM94/fix-rebase
Browse files Browse the repository at this point in the history
rebase-merges: improve --rebase-merges label generation
  • Loading branch information
dscho committed Sep 2, 2019
2 parents 94ef49f + d3d6c4e commit de7827b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
12 changes: 11 additions & 1 deletion sequencer.c
Expand Up @@ -4635,8 +4635,18 @@ static int make_script_with_merges(struct pretty_print_context *pp,
strbuf_addbuf(&label, &oneline);

* Sanitize labels by replacing non-alpha-numeric characters
* (including white-space ones) by dashes, as they might be
* illegal in file names (and hence in ref names).
* Note that we retain non-ASCII UTF-8 characters (identified
* via the most significant bit). They should be all acceptable
* in file names. We do not validate the UTF-8 here, that's not
* the job of this function.
for (p1 = label.buf; *p1; p1++)
if (isspace(*p1))
if (!(*p1 & 0x80) && !isalnum(*p1))
*(char *)p1 = '-';

Expand Down
5 changes: 5 additions & 0 deletions t/
Expand Up @@ -441,4 +441,9 @@ test_expect_success '--continue after resolving conflicts after a merge' '
test_path_is_missing .git/MERGE_HEAD

test_expect_success '--rebase-merges with commit that can generate bad characters for filename' '
git checkout -b colon-in-label E &&
git merge -m "colon: this should work" G &&
git rebase --rebase-merges --force-rebase E

0 comments on commit de7827b

Please sign in to comment.