Skip to content

Commit

Permalink
fixup! mingw: Windows Docker volumes are *not* symbolic links
Browse files Browse the repository at this point in the history
Biiiiig brown paper bag, please. Please, quick. Really quick.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Apr 25, 2018
1 parent 8dd7bac commit df4ca5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion compat/mingw.c
Original file line number Diff line number Diff line change
Expand Up @@ -3566,7 +3566,7 @@ int file_attr_to_st_mode (DWORD attr, DWORD tag, const char *path)
* points and look like symbolic links, but they are not.
*/
if (path && is_inside_windows_container() &&
readlink(path, buf, sizeof(buf) >= 0) &&
readlink(path, buf, sizeof(buf)) > 27 &&
starts_with(buf, "/ContainerMappedDirectories/"))
flag = S_IFDIR;

Expand Down

3 comments on commit df4ca5f

@ZCube
Copy link

@ZCube ZCube commented on df4ca5f Apr 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for really fast patch :)

@donny-dont
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dscho really looking forward to a release with this. Any potential ETA for it?

@dscho
Copy link
Member Author

@dscho dscho commented on df4ca5f Apr 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donny-dont have you even tested the snapshots before demanding to see an ETA yet?

Please sign in to comment.