VS2017 vcxproj #1302
Merged
VS2017 vcxproj #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the PERL script always generates v140 / ToolVersion 14 files. I think we could use |
Toolset v120 corresponds to Visual Studio 2013. We already used dependencies that were hardcoded to v140 (i.e. Visual Studio 2015), so let's just remove the cruft. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Add .LIBs for zlib and openssl to <AdditionalDependencies> to help linker when building with VS2017. This closes git-for-windows#1234 Note: this patch still leaves a couple of TODOs: - It should be possible to add GEN.DEPS\lib to <AdditionalLibraryDependencies> and then just set <AdditionalDependencies> to the library basenames. - Likewise, you should be able to copy GEN.DEPS\bin\*.dll to the destination directory rather than using the full paths in the $afterTargets lines. (This is in line with items in <AdditionalIncludeDirectories> referencing GEN.DEPS\include.) Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
vs2017_vcxproj
branch
from
9af9a7d
to
8a8fa14
Compare
|
Thanks for your contribution, this is excellent and also closes #1234.
A valid point. However, my primary concern with the |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Sep 18, 2017
The `vs/master` branch [can now be built in Visual Studio 2017](git-for-windows/git#1302), too Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
…proj VS2017 vcxproj
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
…proj VS2017 vcxproj
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
…proj VS2017 vcxproj
dscho
added a commit
to dscho/git
that referenced
this pull request
Aug 22, 2018
…proj VS2017 vcxproj
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Aug 28, 2018
…proj VS2017 vcxproj
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 5, 2018
…proj VS2017 vcxproj
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 11, 2018
…proj VS2017 vcxproj
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 12, 2018
…proj VS2017 vcxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix for building inside VS2017 using the generated SLN and VCXPROJ files in vs/master.
For some reason, the existing PERL-generated project files built fine using VS2015, but failed to
link when building with VS2017 (with unsatisfied references in zlib and then openssl).
The fix here, adds explicit .lib references to the AdditionalDependencies parameter. I left a TODO
in the commit message describing a possibly simpler fix.
@dscho Please see if this looks right to you. I managed to get everything to compile and link, but
I wasn't sure how you were using some of the project dependencies and error handling at the bottom
of the resulting vcxproj files, so you may want to refactor this. However you want to handle this is
fine with me. Thanks!