Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: check for whitespace before submitting #1567

Merged
merged 1 commit into from Mar 19, 2018

Conversation

@derrickstolee
Copy link

commented Mar 19, 2018

Whitespace errors are easy to create but hard to check manually. Add
two git commands that detect these whitespace errors to the commit
cleanup section of CONTRIBUTING.md.

CONTRIBUTING.md: check for whitespace before submitting
Whitespace errors are easy to create but hard to check manually. Add
two git commands that detect these whitespace errors to the commit
cleanup section of CONTRIBUTING.md.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@larsxschneider
Copy link
Member

left a comment

Looks good to me 👍

@dscho dscho merged commit 52f89a9 into git-for-windows:master Mar 19, 2018

2 checks passed

DCO All commits have a DCO sign-off from the author
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@dscho

This comment has been minimized.

Copy link
Member

commented Mar 19, 2018

Perfect, thanks, both!

@derrickstolee derrickstolee deleted the derrickstolee:whitespace branch Mar 19, 2018

@PhilipOakley

This comment has been minimized.

Copy link

commented Mar 21, 2018

I tend to notice via the Git Gui, which I usually use to review changes and my commit message. The GIt Gui also has white-space checking available. - Maybe worth noting.

@dscho

This comment has been minimized.

Copy link
Member

commented Mar 22, 2018

Welcome back @PhilipOakley! Yes, that's a good point. Would you mind opening a PR to add this tip?

dscho added a commit that referenced this pull request Mar 23, 2018
Merge pull request #1567 from derrickstolee/whitespace
CONTRIBUTING.md: check for whitespace before submitting
dscho added a commit that referenced this pull request Apr 3, 2018
Merge pull request #1567 from derrickstolee/whitespace
CONTRIBUTING.md: check for whitespace before submitting
dscho added a commit that referenced this pull request May 29, 2018
Merge pull request #1567 from derrickstolee/whitespace
CONTRIBUTING.md: check for whitespace before submitting
dscho added a commit that referenced this pull request May 29, 2018
Merge pull request #1567 from derrickstolee/whitespace
CONTRIBUTING.md: check for whitespace before submitting
dscho added a commit that referenced this pull request May 29, 2018
Merge pull request #1567 from derrickstolee/whitespace
CONTRIBUTING.md: check for whitespace before submitting
dscho added a commit that referenced this pull request May 29, 2018
Merge pull request #1567 from derrickstolee/whitespace
CONTRIBUTING.md: check for whitespace before submitting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.