Support compiling with GCC v9.x #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `labs()` function operates, as the initial `l` suggests, on `long` parameters. However, in `config.c` we tried to use it on values of type `intmax_t`. This problem was found by GCC v9.x. To fix it, let's just "unroll" the function (i.e. negate the value if it is negative). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
orgads
approved these changes
Jul 11, 2019
|
Thanks, both! |
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2019
Support compiling with GCC v9.x
dscho
added a commit
to git-for-windows/git-sdk-32
that referenced
this pull request
Jul 15, 2019
The issues with GCC have been resolved: - The bug in GCC v8.x was fixed that prevented `-fstack-protector-strong` to produce valid code: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86832 - The issues were resolved in Git for Windows' source code that triggered build warnings with GCC v8.x (warnings that cause build failures with `DEVELOPER=1`): git-for-windows/git#2149 - The issue preventing Git for Windows to be compiled with GCC v9.x under `DEVELOPER=1` was resolved: git-for-windows/git#2258 - The issues preventing Git's `master` to be compiled with GCC v9.x (rolling up the fixes for GCC v8.x) were resolved: gitgitgadget/git#265 The issue with osslsigncode no longer signing the code after the upgrade to OpenSSL v1.1.1, but pretending to succeed, has been fixed some time recently through a rebuild of mingw-w64-osslsigncode. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/git-sdk-64
that referenced
this pull request
Jul 15, 2019
The issues with GCC have been resolved: - The bug in GCC v8.x was fixed that prevented `-fstack-protector-strong` to produce valid code: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86832 - The issues were resolved in Git for Windows' source code that triggered build warnings with GCC v8.x (warnings that cause build failures with `DEVELOPER=1`): git-for-windows/git#2149 - The issue preventing Git for Windows to be compiled with GCC v9.x under `DEVELOPER=1` was resolved: git-for-windows/git#2258 - The issues preventing Git's `master` to be compiled with GCC v9.x (rolling up the fixes for GCC v8.x) were resolved: gitgitgadget/git#265 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 23, 2019
Support compiling with GCC v9.x
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 25, 2019
Support compiling with GCC v9.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix already made it into git.git's
master, via gitgitgadget#265.