Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry (or resume) when encountering download errors #89

Closed
rubyist opened this issue Jul 24, 2014 · 3 comments
Labels

Comments

@rubyist
Copy link
Contributor

@rubyist rubyist commented Jul 24, 2014

When the git media client receives an unexpected EOF from the server, it will panic and abort the clone/push. It should retry (or resume) the download.

@technoweenie technoweenie added the bug label Jul 24, 2014
@technoweenie

This comment has been minimized.

Copy link
Member

@technoweenie technoweenie commented Aug 5, 2014

It simply writes to STDERR now. There's no actual retry yet. Right now it just writes the pointer file out to disk if it can't get the media file. But I agree it should retry during the git smudge command.

@technoweenie technoweenie added enhancement and removed bug labels Aug 5, 2014
@feldan

This comment has been minimized.

Copy link

@feldan feldan commented Jun 4, 2015

@technoweenie @rubyist , I'd just like to add it seems like a bug to me - writing the pointer file (which has the exact name as the file itself) can be misleading: i.e. I expect the file to be there and it is - but the content is wrong, now I have to backtrack and understand what messed up (think about a CI server failing a build over this or worse - packaging a release with bad content).
you should not write the pointer if the get failed in my opinion.

@technoweenie

This comment has been minimized.

Copy link
Member

@technoweenie technoweenie commented Feb 23, 2016

We have some retries now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.