Enhanced transfers part 4: resuming uploads via tus.io protocol #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mutex *sync.Mutex | ||
| objects map[string]map[string][]byte | ||
| incomplete map[string]map[string][]byte | ||
| mutex *sync.Mutex |
Contributor
There was a problem hiding this comment.
Why do you need the pointer?
Contributor
Author
There was a problem hiding this comment.
Which pointer? The Mutex is unchanged if that's the one you mean.
Contributor
|
👍 , just some minor comments from me. |
Contributor
Author
|
Tests are currently failing because updating to master has pulled in a flaky test: #1334 |
Contributor
|
Welcome back, @sinbad, and thanks for the speedy fixes. This looks great, and I am really excited to get this into master. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "tus" transfer adapter which uses the tus.io resumable upload protocol (HEAD/PATCH methods). This allows a server to share upload action links to an endpoint which supports this protocol and therefore allow upload resuming.
The included tests implement the server protocol too to prove it works, and I'm also submitting a PR to lfs-test-server which uses the official
tusdserver to prove it works using the official implementation and to demonstrate how you might go about using it.