Possibility to use committer as "From" in generated mails

[rhertzog]

We have a limited set of committers and we like to see who commited directly in the "From" field. Please make it possible to use that identity in the From field ideally with a simple setting, otherwise at least with wrapper script.

Right now, it's not possible to override get_fromaddr() of the Environment because it doesn't get the details of the commit or from the changes.

[mhagger]

Does the "computed-from" branch that I just pushed do what you need? It changes the callers of get_fromaddr() to pass a Change instance to the method when one is available. You could override Environment.get_fromaddr() with code like

if isinstance(change, Revision):
    ....
elif isinstance(change, ReferenceChange):
    ....
else:
    # change can be None, too, if called when instantiating an SMTPMailer if environment.get_sender() does
    # not return a value; in that case you have to return something here, too.

[rhertzog]

Yes, looks like so. It would be even easier if Revision extracted the committer information too at the same time it takes care of the author.

[catalin-hritcu]

I'm a git and git-multimail noob, and just noticed that some commit messages were marked as spam because of the completely made up FROM address. I would like to use the committer's address in FROM. How can I do that?

[catalin-hritcu]

Never mind. I've found a hacky way of doing this by passing the user email in as an environment variable that is assigned the result of

$(git log -1 --format=format:%ae HEAD)

and then overriding get_fromaddr to use this. It's not nice, but it works.

[moy]

Fixed by #99.

[catalin-hritcu]

This works great, thanks a lot!