Generates invalid Reply-To header in some situations #33

Closed
rhertzog opened this Issue Aug 6, 2013 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

rhertzog commented Aug 6, 2013

FWIW I have setup git-multimail on git.debian.org and many people are now using it. I just got a report of some invalid mail generated by git-multimail. When a user pushed this commit: http://anonscm.debian.org/gitweb/?p=lintian/lintian.git;a=commit;h=3bbaa34ddf253dfdd9aee041e8d571a97e73584e

He got back a bounce saying "550 Message headers fail syntax check" (this is exim giving back this answer) and the only thing that looks weird in the mail is the Reply-to header:

Return-path: <nthykier@vasks.debian.org>
Received: from nthykier by vasks.debian.org with local (Exim 4.80)
    (envelope-from <nthykier@vasks.debian.org>)
    id 1V6dV3-0005q4-Qc; Tue, 06 Aug 2013 09:24:17 +0000
To: debian-lint-maint@lists.debian.org
Subject: [lintian] 02/03: Add generic infrastructure for checking
 common-licenses
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Reply-To: =?utf-8?q?_Bastien_ROUCARI=C3=88S_=3Croucaries=2Ebastien=40gmai?=
 =?utf-8?b?bC5jb20+?=
In-Reply-To: <20130806092415.22375.96493@vasks.debian.org>
References: <20130806092415.22375.96493@vasks.debian.org>
X-Git-Repo: lintian
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Rev: 3bbaa34ddf253dfdd9aee041e8d571a97e73584e
Auto-Submitted: auto-generated
Message-Id: <E1V6dV3-0005q4-Qc@vasks.debian.org>
From: Niels Thykier <nthykier@vasks.debian.org>
Date: Tue, 06 Aug 2013 09:24:17 +0000

Any idea what's going wrong here?

Note that git-format-patch outputs “From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?= roucaries.bastien@gmail.com” so it definitely encodes the identity/email more wisely.

Contributor

rhertzog commented Aug 6, 2013

The detailed log on the server says:

2013-08-06 09:24:23 1V6dV9-0005hD-2e H=vasks.debian.org [217.196.43.140] F=<nthykier@alioth.debian.org> rejected after DATA: missing or malformed local part (expected word or "<"): failing address in "Reply-To:" header is: =?utf-8?q?_Bastien_ROUCARI=C3=88S_=3Croucaries=2Ebastien=40gmai?=\n =?utf-8?b?bC5jb20+?=

Apparently the RFC do not allow to encode everything but only the name... so this is a bug in git-multimail (or the underlying Python modules).

Contributor

moy commented Aug 6, 2013 edited

Previous revisions used to leave the complete field unencoded (see merge request #18). The Python modules to do the encoding are not very convenient to use (IIRC, by default it encoded even the field name, and used QP unconditionally even for pure ascii content), and I already had to fight a bit to get it mostly right. I guess we'll have to special case From, To and Reply-To and email-parse them before encoding. No time to work on this right now, sorry.

Contributor

mhagger commented Aug 8, 2013

This issue is fixed by 13e66ca.

mhagger closed this Aug 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment