Workspace fix #328

Merged
merged 12 commits into from Apr 5, 2013

2 participants

@spraints
git-tfs member

Fixes #327.

@spraints
git-tfs member

@szmartynuska - thanks for getting this started! How does this look?

@szmartynuska

Finally got around to check it and now the temp workspace is properly deleted. Found another issue though - cleaning up workspace while having more than one mapping doesn't realy work because it tries to compare mappings' paths with (by default) path to internal directory ".git\tfs\default\workspace". Made a fix at szmartynuska@46b75dc5d9a086fb90d4a6421dbbd504b7d3481c. It now deletes all mappings to any folder in the working directory path, which is required for the MappingConflictException not to be thrown.

spraints added some commits Apr 4, 2013
@spraints spraints tweak c13a1de
@spraints spraints Interweave some comments.
I'm normally not big on comments, but I thought I could validate my
reading of the code and answer future questions at the same time.
4d33862
@spraints
git-tfs member

@szmartynuska - I pulled in your change, and made a couple of tweaks. Could you look over the comments in 4d33862 and let me know if they look right?

@szmartynuska

They sound ok, as far as I'm concerned.

@spraints spraints merged commit 9467fad into master Apr 5, 2013

1 check passed

Details default The Travis build passed
@spraints spraints deleted the workspace-fix branch Apr 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment