Optimize fetching of a branch changeset #522

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

kgybels commented Jan 5, 2014

If a change is only a branch operation and we already have a file at the
target path, then there is nothing to do for that change.

close #303

@kgybels kgybels Optimize fetching of a branch changeset
If a change is only a branch operation and we already have a file at the
target path, then there is nothing to do for that change.

close #303
f635b5c
Contributor

kgybels commented Jan 9, 2014

What I actually wanted to check was that the branch change is the only operation for a certain path. The current check is sufficient for TFS 2010 and later (i.e. slot mode), but not for earlier TFS that operates in item mode, because then we can have multiple operations to the same path but in different changes.

E.g. one change says the path is deleted, and another change says a file is branched to that same path. In this case we do need to get the new file. Note that this is different than having one change that is marked with both branch and delete. Changes like the latter we can ignore if we want. To produce such a change in TFS, you need to branch a folder and then delete a descendant of it.

Contributor

sc68cal commented Jan 10, 2014

👍

Owner

spraints commented Jan 15, 2014

Nice! Can you update it to work well with the latest master (#519 is the big conflict)? The new ChangeSieve class should make testing some of this easier. Also, an integration test or two that demonstrates what this is doing would be 🎆.

Contributor

kgybels commented Jan 15, 2014

Yes, so many things to do, so little time though 😪

Contributor

KindDragon commented Mar 1, 2014

kgybels closed this Dec 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment