correct `--nofetch` option #551

Merged
merged 1 commit into from Mar 7, 2014

2 participants

@pmiossec
git-tfs member

according to doc, error messages and old init-branch command...

@pmiossec pmiossec referenced this pull request Mar 7, 2014
Closed

New release? #451

@spraints
git-tfs member

I prefer --no-fetch over --nofetch. Can we fix the docs instead?

@pmiossec
git-tfs member

I prefer --no-fetch over --nofetch. Can we fix the docs instead?

In not just a problem of docs. --nofetch was the name of the option until I made a typo and in one command, that was named --no-fetch.

So, there is one or more places where we should fix the name of the option depending what we choose. There is just more places if we choose --no-fetch but we can choose what we want...

@spraints spraints referenced this pull request Mar 7, 2014
Closed

v0.20.0 #559

12 of 12 tasks complete
@pmiossec
git-tfs member

same PR with choosing --no-fetch option instead...

@spraints
git-tfs member

I didn't realize it was in so many places. If you git tfs whatever --nofetch does git-tfs tell you that --nofetch isn't recognized, or does it go ahead and do the fetch anyway?

@pmiossec
git-tfs member

It was introduced in the init-branch command and reported in the branch command (losing the '-' in the process :( ) when the command was created to deprecate init-branch. That's used only here.

I don't think it's a big problem to change the name of the option. The option was asked by @davidalpert but I'm not sure there is someone using it (even perhaps him!).

And git-tfs don't permit to use an option that do not exists and display the help of the command in this case (and do nothing). So, not a big deal. We could rename and choose the one we want...

@spraints
git-tfs member

:metal:

@spraints spraints merged commit 8d0711e into git-tfs:master Mar 7, 2014

1 check passed

Details default The Travis CI build passed
@pmiossec pmiossec deleted the pmiossec:correct_nofetch_flag branch Mar 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment