I was unable to create a shelfset (error TF14045)

[caseykramer]

It was trying to use to get existing selfsets. This change fixed things for me. Not sure if it is something other folks are running into or not.

Detauls:
Replaced implementation of GetAuthenticatedUser with a call to VersionControl.AuthorizedUser. The old version was returning ' ' which was throwing back an identity error when trying to fetch existing shelfsets

[spraints]

I'm not sure that this works always. In d4b2880 the opposite change was made. What do the two versions of GetAuthenticatedUser() return?

[caseykramer]

Yeah, I was afraid of that....In my case the original version returned "Casey Kramer", while the updated version returns "domain\ckramer", which matches my credentials on the TFS server. I have to assume there is some form of config or user-specific setting that plays into this somehow....but then maybe not. I've not worked with TFS at the API layer much, so who knows.

If it is helpful, they actually updated our TFS server from 2008 to 2010 recently, and I encountered this problem on both versions.

[spraints]

ListShelvesets uses VersionControl.AuthorizedUser. It sounded like that's where you wanted it, but I must be missing something.

[ivan-danilov]

It is list and unshelve. Shelve command uses exactly what Casey has changed.
Will check if it really works tomorrow and pick it as a fix into both master and 0-12-stable branches.

[ivan-danilov]

P.S. Matt, in version you mentioned it was changed from AuthenticatedUser which is obsolete according to MS docs. And in this version it is changed to AuthorizedUser. So I think it is correct now. But as I said I will check it nevertheless.

[caseykramer]

I believe I used whichever the property was that was not obsolete....can't
recall off the top of my head which it was tho.
On Aug 16, 2011 7:37 PM, "ivan-danilov" <
reply@reply.github.com>
wrote:

P.S. Matt, in version you mentioned it was changed from
AuthenticatedUser which is obsolete according to MS docs. And in this
version it is changed to AuthorizedUser. So I think it is correct now. But
as I said I will check it nevertheless.

Reply to this email directly or view it on GitHub:
https://github.com/spraints/git-tfs/pull/76#issuecomment-1821684

[ivan-danilov]

It works for me. And in google groups there's yet one complaint on the same problem. I believe it will be resolved also.

Cherry-picked to 0-12-stable and master branches. Thanks.