Pressing “Stage All” doesn’t stage the submodule commit update

[richardtop]

[lucasderraugh]

@richardtop Did you make uncommitted changes to openssl? I find that if I'm just changing the submodule commit, then stage all works fine. However, if I have uncommitted changes in the submodule, and try to stage it from the parent, it won't work because we can't commit on behalf of the submodule.

I do find working with submodules a bit clunky in GitUp, but if you have practical suggestions around what I just stated above I'm all ears.

[richardtop]

Yeah, I think I've made some changes to the submodule. I think, in this case, "discard all" should either discard all of the changes to the submodule, or at least show some warning.

Another solution in case of a submodule having uncommitted changes is to show a button "open in GitUp" to open another instance of GitUp with that repo, so that it's possible to discard changes there.

[lucasderraugh]

A recursive discard could work, but I don't know about a stage as the changes would need to be committed.

It's a bit of a balance as I don't want to always interrupt the flows when people make changes in the current repo and want to commit those but don't need the submodule changes committed just yet.

On a side note, there is Repository > Open Submodule… > [submodule] where you can open that in a new window (or option-key will open in current window). You can also do it from the gear in the top right when you select the submodule in the commit view.

[richardtop]

On a side note, there is Repository > Open Submodule… > [submodule] where you can open that in a new window (or option-key will open in current window). You can also do it from the gear in the top right when you select the submodule in the commit view.

I think it's better to have a button next to the submodule or in the button row "Discard all" "Stage all", or somewhere nearby that allows opening a submodule git repo in one click