Browse files

fast-import: Fix an gcc -Wuninitialized warning

Commit cbfd5e1 ("drop some obsolete "x = x" compiler warning hacks",
21-03-2013) removed a gcc hack that suppressed an "might be used
uninitialized" warning issued by older versions of gcc.

However, commit 3aa99df ('fast-import: clarify "inline" logic in
file_change_m', 21-03-2013) addresses an (almost) identical issue
(with very similar code), but includes additional code in it's
resolution. The solution used by this commit, unlike that used by
commit cbfd5e1, also suppresses the -Wuninitialized warning on
older versions of gcc.

In order to suppress the warning (against the 'oe' symbol) in the
note_change_n() function, we adopt the same solution used by commit

Signed-off-by: Ramsay Jones <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent 5e950c2 commit 0a34594c8340f5cf246592ec08d330901ea8951e Ramsay Jones committed with gitster Mar 26, 2013
Showing with 1 addition and 0 deletions.
  1. +1 −0 fast-import.c
@@ -2465,6 +2465,7 @@ static void note_change_n(struct branch *b, unsigned char *old_fanout)
hashcpy(sha1, oe->idx.sha1);
} else if (!prefixcmp(p, "inline ")) {
inline_data = 1;
+ oe = NULL; /* not used with inline_data, but makes gcc happy */
p += strlen("inline"); /* advance to space */
} else {
if (get_sha1_hex(p, sha1))

0 comments on commit 0a34594

Please sign in to comment.