Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

archive: re-allow HEAD:Documentation on a remote invocation

The tightening done in (ee27ca4: archive: don't let remote clients
get unreachable commits, 2011-11-17) went too far and disallowed
HEAD:Documentation as it would try to find "HEAD:Documentation" as a

Only DWIM the "HEAD" part to see if it exists as a ref. Once we're
sure that we've been given a valid ref, we follow the normal code
path. This still disallows attempts to access commits which are not
branch tips.

Signed-off-by: Carlos Martín Nieto <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
commit 0f544ee897ac2cc760f29d3568cc4295ca69fd1f 1 parent 7b51c33
@carlosmn carlosmn authored gitster committed
Showing with 15 additions and 6 deletions.
  1. +15 −6 archive.c
21 archive.c
@@ -260,14 +260,23 @@ static void parse_treeish_arg(const char **argv,
/* Remotes are only allowed to fetch actual refs */
if (remote) {
char *ref = NULL;
- if (!dwim_ref(name, strlen(name), sha1, &ref))
- die("no such ref: %s", name);
+ const char *refname, *colon = NULL;
+ colon = strchr(name, ':');
+ if (colon)
+ refname = xstrndup(name, colon - name);
+ else
+ refname = name;
+ if (!dwim_ref(refname, strlen(refname), sha1, &ref))
+ die("no such ref: %s", refname);
+ if (refname != name)
+ free((void *)refname);
- else {
- if (get_sha1(name, sha1))
- die("Not a valid object name");
- }
+ if (get_sha1(name, sha1))
+ die("Not a valid object name");
commit = lookup_commit_reference_gently(sha1, 1);
if (commit) {
Please sign in to comment.
Something went wrong with that request. Please try again.