Skip to content

Commit

Permalink
Add --depth to submodule update/add
Browse files Browse the repository at this point in the history
Add the --depth option to the add and update commands of "git submodule",
which is then passed on to the clone command. This is useful when the
submodule(s) are huge and you're not really interested in anything but
the latest commit.

Tests are added and some indention adjustments were made to conform to the
rest of the testfile on "submodule update can handle symbolic links in pwd".

Signed-off-by: Fredrik Gustafsson <iveqy@iveqy.com>
Acked-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
iveqy authored and gitster committed Jul 3, 2013
1 parent edca415 commit 275cd18
Show file tree
Hide file tree
Showing 4 changed files with 61 additions and 12 deletions.
10 changes: 8 additions & 2 deletions Documentation/git-submodule.txt
Expand Up @@ -10,12 +10,12 @@ SYNOPSIS
-------- --------
[verse] [verse]
'git submodule' [--quiet] add [-b <branch>] [-f|--force] [--name <name>] 'git submodule' [--quiet] add [-b <branch>] [-f|--force] [--name <name>]
[--reference <repository>] [--] <repository> [<path>] [--reference <repository>] [--depth <depth>] [--] <repository> [<path>]
'git submodule' [--quiet] status [--cached] [--recursive] [--] [<path>...] 'git submodule' [--quiet] status [--cached] [--recursive] [--] [<path>...]
'git submodule' [--quiet] init [--] [<path>...] 'git submodule' [--quiet] init [--] [<path>...]
'git submodule' [--quiet] deinit [-f|--force] [--] <path>... 'git submodule' [--quiet] deinit [-f|--force] [--] <path>...
'git submodule' [--quiet] update [--init] [--remote] [-N|--no-fetch] 'git submodule' [--quiet] update [--init] [--remote] [-N|--no-fetch]
[-f|--force] [--rebase] [--reference <repository>] [-f|--force] [--rebase] [--reference <repository>] [--depth <depth>]
[--merge] [--recursive] [--] [<path>...] [--merge] [--recursive] [--] [<path>...]
'git submodule' [--quiet] summary [--cached|--files] [(-n|--summary-limit) <n>] 'git submodule' [--quiet] summary [--cached|--files] [(-n|--summary-limit) <n>]
[commit] [--] [<path>...] [commit] [--] [<path>...]
Expand Down Expand Up @@ -328,6 +328,12 @@ for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully.
only in the submodules of the current repo, but also only in the submodules of the current repo, but also
in any nested submodules inside those submodules (and so on). in any nested submodules inside those submodules (and so on).


--depth::
This option is valid for add and update commands. Create a 'shallow'
clone with a history truncated to the specified number of revisions.
See linkgit:git-clone[1]


<path>...:: <path>...::
Paths to submodule(s). When specified this will restrict the command Paths to submodule(s). When specified this will restrict the command
to only operate on the submodules found at the specified paths. to only operate on the submodules found at the specified paths.
Expand Down
24 changes: 21 additions & 3 deletions git-submodule.sh
Expand Up @@ -32,6 +32,7 @@ nofetch=
update= update=
prefix= prefix=
custom_name= custom_name=
depth=


# The function takes at most 2 arguments. The first argument is the # The function takes at most 2 arguments. The first argument is the
# URL that navigates to the submodule origin repo. When relative, this URL # URL that navigates to the submodule origin repo. When relative, this URL
Expand Down Expand Up @@ -211,6 +212,7 @@ module_clone()
name=$2 name=$2
url=$3 url=$3
reference="$4" reference="$4"
depth="$5"
quiet= quiet=
if test -n "$GIT_QUIET" if test -n "$GIT_QUIET"
then then
Expand All @@ -233,7 +235,7 @@ module_clone()
mkdir -p "$gitdir_base" mkdir -p "$gitdir_base"
( (
clear_local_git_env clear_local_git_env
git clone $quiet -n ${reference:+"$reference"} \ git clone $quiet ${depth:+"$depth"} -n ${reference:+"$reference"} \
--separate-git-dir "$gitdir" "$url" "$sm_path" --separate-git-dir "$gitdir" "$url" "$sm_path"
) || ) ||
die "$(eval_gettext "Clone of '\$url' into submodule path '\$sm_path' failed")" die "$(eval_gettext "Clone of '\$url' into submodule path '\$sm_path' failed")"
Expand Down Expand Up @@ -309,6 +311,14 @@ cmd_add()
custom_name=$2 custom_name=$2
shift shift
;; ;;
--depth)
case "$2" in '') usage ;; esac
depth="--depth=$2"
shift
;;
--depth=*)
depth=$1
;;
--) --)
shift shift
break break
Expand Down Expand Up @@ -405,7 +415,7 @@ Use -f if you really want to add it." >&2
echo "$(eval_gettext "Reactivating local git directory for submodule '\$sm_name'.")" echo "$(eval_gettext "Reactivating local git directory for submodule '\$sm_name'.")"
fi fi
fi fi
module_clone "$sm_path" "$sm_name" "$realrepo" "$reference" || exit module_clone "$sm_path" "$sm_name" "$realrepo" "$reference" "$depth" || exit
( (
clear_local_git_env clear_local_git_env
cd "$sm_path" && cd "$sm_path" &&
Expand Down Expand Up @@ -676,6 +686,14 @@ cmd_update()
--checkout) --checkout)
update="checkout" update="checkout"
;; ;;
--depth)
case "$2" in '') usage ;; esac
depth="--depth=$2"
shift
;;
--depth=*)
depth=$1
;;
--) --)
shift shift
break break
Expand Down Expand Up @@ -735,7 +753,7 @@ Maybe you want to use 'update --init'?")"


if ! test -d "$sm_path"/.git -o -f "$sm_path"/.git if ! test -d "$sm_path"/.git -o -f "$sm_path"/.git
then then
module_clone "$sm_path" "$name" "$url" "$reference" || exit module_clone "$sm_path" "$name" "$url" "$reference" "$depth" || exit
cloned_modules="$cloned_modules;$name" cloned_modules="$cloned_modules;$name"
subsha1= subsha1=
else else
Expand Down
15 changes: 15 additions & 0 deletions t/t7400-submodule-basic.sh
Expand Up @@ -868,4 +868,19 @@ test_expect_success 'submodule deinit fails when submodule has a .git directory
test -n "$(git config --get-regexp "submodule\.example\.")" test -n "$(git config --get-regexp "submodule\.example\.")"
' '


test_expect_success 'submodule add clone shallow submodule' '
mkdir super &&
pwd=$(pwd)
(
cd super &&
git init &&
git submodule add --depth=1 file://"$pwd"/example2 submodule &&
(
cd submodule &&
test 1 = $(git log --oneline | wc -l)
)
)
'


test_done test_done
24 changes: 17 additions & 7 deletions t/t7406-submodule-update.sh
Expand Up @@ -685,14 +685,24 @@ test_expect_success 'submodule update properly revives a moved submodule' '
test_expect_success SYMLINKS 'submodule update can handle symbolic links in pwd' ' test_expect_success SYMLINKS 'submodule update can handle symbolic links in pwd' '
mkdir -p linked/dir && mkdir -p linked/dir &&
ln -s linked/dir linkto && ln -s linked/dir linkto &&
( (cd linkto &&
cd linkto && git clone "$TRASH_DIRECTORY"/super_update_r2 super &&
git clone "$TRASH_DIRECTORY"/super_update_r2 super && (cd super &&
( git submodule update --init --recursive
cd super && )
git submodule update --init --recursive
)
) )
' '


test_expect_success 'submodule update clone shallow submodule' '
git clone cloned super3 &&
pwd=$(pwd)
(cd super3 &&
sed -e "s#url = ../#url = file://$pwd/#" <.gitmodules >.gitmodules.tmp &&
mv -f .gitmodules.tmp .gitmodules &&
git submodule update --init --depth=3
(cd submodule &&
test 1 = $(git log --oneline | wc -l)
)
)
'
test_done test_done

0 comments on commit 275cd18

Please sign in to comment.