Permalink
Browse files

Make usage of windows.h lean and mean

Centralize the include of windows.h in git-compat-util.h, turn on
WIN32_LEAN_AND_MEAN to avoid including plenty of other header files
which is not needed in Git. Also ensure we load winsock2.h first,
so we don't load the older winsock definitions at a later stage,
since they contain duplicate definitions.

When moving windows.h into git-compat-util.h, we need to protect
the definition of struct pollfd in mingw.h, since this file is used
by both MinGW and MSVC, and the latter defines this struct in
winsock2.h.

We need to keep the windows.h include in compat/win32.h, since its
shared by both MinGW and Cygwin, and we're not touching Cygwin in
this commit. The include in git-compat-util.h is protected with an
ifdef WIN32, which is not the case when compiling for Cygwin.

Signed-off-by: Marius Storm-Olsen <mstormo@gmail.com>
Acked-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information...
1 parent d75f8e6 commit 435bdf8c7ffa493f8f6f2e8f329f8cc22db16ce6 @mstormo mstormo committed with gitster Sep 16, 2009
Showing with 13 additions and 12 deletions.
  1. +2 −0 compat/mingw.c
  2. +2 −0 compat/mingw.h
  3. +0 −7 compat/msvc.h
  4. +2 −0 compat/win32.h
  5. +0 −1 compat/winansi.c
  6. +6 −0 git-compat-util.h
  7. +1 −4 thread-utils.c
View
@@ -3,6 +3,8 @@
#include <conio.h>
#include "../strbuf.h"
+#include <shellapi.h>
+
static int err_win_to_posix(DWORD winerr)
{
int error = ENOSYS;
View
@@ -41,13 +41,15 @@ struct passwd {
extern char *getpass(const char *prompt);
+#ifndef POLLIN
struct pollfd {
int fd; /* file descriptor */
short events; /* requested events */
short revents; /* returned events */
};
#define POLLIN 1
#define POLLHUP 2
+#endif
typedef void (__cdecl *sig_handler_t)(int);
struct sigaction {
View
@@ -1,13 +1,6 @@
#ifndef __MSVC__HEAD
#define __MSVC__HEAD
-/* Define minimize windows version */
-#define WINVER 0x0500
-#define _WIN32_WINNT 0x0500
-#define _WIN32_WINDOWS 0x0410
-#define _WIN32_IE 0x0700
-#define NTDDI_VERSION NTDDI_WIN2KSP1
-#include <winsock2.h>
#include <direct.h>
#include <process.h>
#include <malloc.h>
View
@@ -2,7 +2,9 @@
#define WIN32_H
/* common Win32 functions for MinGW and Cygwin */
+#ifndef WIN32 /* Not defined by Cygwin */
#include <windows.h>
+#endif
static inline int file_attr_to_st_mode (DWORD attr)
{
View
@@ -2,7 +2,6 @@
* Copyright 2008 Peter Harris <git@peter.is-a-geek.org>
*/
-#include <windows.h>
#include "../git-compat-util.h"
/*
View
@@ -65,6 +65,12 @@
#define _NETBSD_SOURCE 1
#define _SGI_SOURCE 1
+#ifdef WIN32 /* Both MinGW and MSVC */
+#define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */
+#include <winsock2.h>
+#include <windows.h>
+#endif
+
#include <unistd.h>
#include <stdio.h>
#include <sys/stat.h>
View
@@ -1,9 +1,6 @@
#include "cache.h"
-#ifdef _WIN32
-# define WIN32_LEAN_AND_MEAN
-# include <windows.h>
-#elif defined(hpux) || defined(__hpux) || defined(_hpux)
+#if defined(hpux) || defined(__hpux) || defined(_hpux)
# include <sys/pstat.h>
#endif

0 comments on commit 435bdf8

Please sign in to comment.