Browse files

git p4: standardize submit cancel due to unchanged template

When editing the submit template, if no change was made to it,
git p4 offers a prompt "Submit anyway?".  Answering "no" cancels
the submit.

Previously, a "no" answer behaves like a "[s]kip" answer to the
failed-patch prompt, in that it proceeded to try to apply the
rest of the commits.  Instead, put users back into the new
"[s]kip / [c]ontinue" loop so that they can decide.  This makes
both cases of patch failure behave identically.

The return code of git p4 after a "no" answer is now the same
as that for a "skip" due to failed patch; update a test to
understand this.

Signed-off-by: Pete Wyckoff <>
Acked-by: Luke Diamand <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent 7e5dd9f commit 5a41c16a81927bbccbcb00895b168a6d560b8c2c Pete Wyckoff committed with gitster Sep 9, 2012
Showing with 4 additions and 2 deletions.
  1. +3 −1
  2. +1 −1 t/
@@ -1262,6 +1262,7 @@ def applyCommit(self, id):
if self.edit_template(fileName):
# read the edited message and submit
+ ret = True
tmpFile = open(fileName, "rb")
message =
@@ -1285,6 +1286,7 @@ def applyCommit(self, id):
# skip this patch
+ ret = False
print "Submission cancelled, undoing p4 changes."
for f in editedFiles:
@@ -1293,7 +1295,7 @@ def applyCommit(self, id):
- return True # success
+ return ret
# Export git tags as p4 labels. Create a p4 label and then tag
# with that.
@@ -38,7 +38,7 @@ test_expect_success 'no config, unedited, say no' '
cd "$git" &&
echo line >>file1 &&
git commit -a -m "change 3 (not really)" &&
- printf "bad response\nn\n" | git p4 submit &&
+ printf "bad response\nn\n" | test_expect_code 1 git p4 submit &&
p4 changes //depot/... >wc &&
test_line_count = 2 wc

0 comments on commit 5a41c16

Please sign in to comment.