Permalink
Browse files

send-email: don't call methods on undefined values

If SSL verification is enabled in git send-email, we could attempt to call a
method on an undefined value if the verification failed, since $smtp would end
up being undef.  Look up the error string in a way that will produce a helpful
error message and not cause further errors.

Signed-off-by: Brian M. Carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information...
1 parent 07b83b5 commit 6cb0c883052118c35e424af7a311c66be9b366e1 @bk2204 bk2204 committed with gitster Sep 8, 2013
Showing with 1 addition and 1 deletion.
  1. +1 −1 git-send-email.perl
View
@@ -1234,7 +1234,7 @@ sub send_message {
if ($smtp->code == 220) {
$smtp = Net::SMTP::SSL->start_SSL($smtp,
ssl_verify_params())
- or die "STARTTLS failed! ".$smtp->message;
+ or die "STARTTLS failed! ".IO::Socket::SSL::errstr();
$smtp_encryption = '';
# Send EHLO again to receive fresh
# supported commands

0 comments on commit 6cb0c88

Please sign in to comment.