Permalink
Browse files

t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression

Regular expressions matched by 'expr' have an implicit '^' at the beginning
of them and so are anchored to the beginning of the string.  Using the '^'
character to mean "match at the beginning", is redundant and could produce
the wrong result if 'expr' implementations interpret the '^' as a literal
'^'.  Additionally, GNU expr 5.97 complains like this:

   expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information...
drafnel authored and gitster committed Jun 21, 2010
1 parent 0af88c1 commit 832ac79edf0e0e9108f5da5b10b496a227667f40
Showing with 1 addition and 1 deletion.
  1. +1 −1 t/lib-pager.sh
View
@@ -9,7 +9,7 @@ test_expect_success 'determine default pager' '
test -n "$less"
'
-if expr "$less" : '^[a-z][a-z]*$' >/dev/null
+if expr "$less" : '[a-z][a-z]*$' >/dev/null
then
test_set_prereq SIMPLEPAGER
fi

0 comments on commit 832ac79

Please sign in to comment.